Attention is currently required from: Nico Huber, Subrata Banik, Edward O'Callaghan, Angel Pons.
5 comments:
Commit Message:
Also, drops unused macros (PCH100_HSFC_FCYCLE_OFF and
PCH100_HSFC_FCYCLE).
Can you extract this into a separate patch? Seems like these are two different things (corresponding to 1st and 2nd paragraph in commit message).
I see you are using brya to test this chain, if you could add info what chipset brya has, it would be very useful.
(and the same for all other patches in the chain ;)
File ichspi.c:
Patch Set #3, Line 80: /* Changed HSFC Control bits */
Should the comment be removed as well?
Patch Set #3, Line 500: reg_val, ", ");
No new line needed, this print statement can be on one line
https://www.flashrom.org/Development_Guidelines#Coding_style
Patch Set #3, Line 505: reg_val, ", ");
Same as previous
To view, visit change 62891. To unsubscribe, or for help writing mail filters, visit settings.