Attention is currently required from: Nico Huber, Edward O'Callaghan, Neill Corlett.

View Change

3 comments:

• File mediatek_i2c_spi.c:

  • Patch Set #1, Line 96: args.data->block

    This is copying the data out of the i2c_smbus_data, starting at 1, using the size specified by [0].

    I imagine Edward would like to avoid pointer arithmetics, substituting `args.data->block + 1` with `&args.data->block[1]`.

  • Patch Set #1, Line 242: GPIO line

    This is specific to the revision of chip that our board uses (TSUMOP82JUQ).

    At the very least, I'd add an option to enable WP# control.

  • Patch Set #1, Line 249: 0x426, 7

    The TSUMOP82JUQ has a GPIO line going to WP# on SPI, and these two registers (0x426 and 0x428) contr […]

    Hmmm, I see. Could other boards with the same chip use a different GPIO for WP#?

To view, visit change 61288. To unsubscribe, or for help writing mail filters, visit settings.