Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Nikolai Artemiev.

3 comments:

Patchset:
- Patch Set #1:
  Joursoir, so glad to see you here, thanks for the patch!
  I'm happy to help!
- Patch Set #1:
  This memory leak was introduced with CB:58738 cli_classic. […]
  Should I add this to the commit message, or is it just the message to anyone?
File cli_classic.c:
- Patch Set #1, Line 1103: if (set_wp_region && wp_region)
  I am wondering whether this condition needed. Maybe we can just have one line […]
  Theoretically, yes. If pointer is a null-pointer, no action would occur. But I'm not sure if this behavior is part of C standard.
  It makes no sense to check if set_wp_region is set, so at least I'll change it to
```
```
  if (wp_region)  
      free(wp_region);
```
```

To view, visit change 64351. To unsubscribe, or for help writing mail filters, visit settings.