Attention is currently required from: Daniel Kurtz, Edward O'Callaghan, Angel Pons.

View Change

3 comments:

• File it85spi.c:

  • Patch Set #11, Line 22:

    
    #if defined(__i386__) || defined(__x86_64__)
    

    In answer to your questions regarding 'LPC_IO' && 'LPC_MEMORY'; probably we have a simple initial pa […]

    Thank you for explanations! Based on our conversation (and comments from other people here), I will do this in a separate patch.

  • Patch Set #11, Line 59:

    /* IT8502 supports two access modes:
     *   LPC_MEMORY: through the memory window in 0xFFFFFxxx (follow mode)
     *   LPC_IO: through I/O port (so called indirect memory)
     */
    #undef LPC_MEMORY
    #define LPC_IO
    

    this would need to be moved above the initial guard, the slightly better fix is that the Makefile pa […]

    Thank you! Same as above, I will do this in a separate patch.

  • Patch Set #11, Line 77: unsigned int shm_io_base;

    Let's not forget that this code is currently disabled (built, but not executed), because it can resu […]

    I returned back ifdef-endif around shm_io_base.
    I agree this should be in a separate commit.

To view, visit change 47655. To unsubscribe, or for help writing mail filters, visit settings.