Attention is currently required from: Aarya, Edward O'Callaghan, Nikolai Artemiev, Simon Buhrow, Thomas Heijligen.
7 comments:
File tests/erase_func_algo.c:
Patch Set #3, Line 238: void **state
`g_state` should probably be passed in here.
I will check cmocka docs how to do it, keep this unresolved for now.
Patch Set #3, Line 282: uint8_t *const newcontents = malloc(MIN_BUF_SIZE);
`uint8_t newcontents[MIN_BUF_SIZE];`
Done
`&n`
Done
`&n`
Done
free(newcontents);
drops lines 313&&314.
Done
File tests/erase_func_algo.c:
Patch Set #5, Line 37: uint8_t buf[MOCK_CHIP_SIZE]; /* Contents of the mock chip. */
Can buf be moved into struct all_state?
Yes! I did it.
But I wanted to clarify about:
> Then the test_case struct will only contain test parameters and can be const.
What exactly do you mean?
Patch Set #5, Line 501: memcmp
This should probably be`!memcmp(... […]
Yes, makes sense. I changed so that now all three
chip_erased
eraseblocks_in_order
eraseblocks_invocations
mean what their names mean.
However `!` has now moved further below, because I still need the final result to be 0 for success. But hope that's fine.
To view, visit change 67535. To unsubscribe, or for help writing mail filters, visit settings.