Attention is currently required from: Arnaud Ferraris, Maximilian Brune.
Patch set 2:Code-Review +2
View Change
1 comment:
File linux_mtd.c:
Patch Set #2, Line 52: char path[sizeof(LINUX_MTD_SYSFS_ROOT) + 32];
Oh I got worried that I missed something.
Size has changed because, it's +1 longer because now it counts `\0` char, is that correct? and it's fine because the same data still fits in.
Yes, maybe 1-line in commit message:
The result is the array init with +1 longer size, because sizeof in the case counts \0 char. (which is fine)
or something like that
To view, visit change 84856. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: If470a65702e9ae08e4303123a0014e53a1fee56e
Gerrit-Change-Number: 84856
Gerrit-PatchSet: 2
Gerrit-Owner: Arnaud Ferraris <arnaud.ferraris@collabora.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Maximilian Brune <maximilian.brune@9elements.com>
Gerrit-Attention: Arnaud Ferraris <arnaud.ferraris@collabora.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune@9elements.com>
Gerrit-Comment-Date: Tue, 29 Oct 2024 01:06:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Maximilian Brune <maximilian.brune@9elements.com>