Attention is currently required from: Peter Marheine, Richard Hughes, Sergii Dmytruk.

View Change

1 comment:

• File include/libflashrom.h:

  • Patch Set #1, Line 93: __attribute__((deprecated("Use flashrom_set_progress_callback_v1 instead")));

    I couldn't do it, got confused along the way - maybe I just went into the wrong rabbit hole?

    I don't know how to guard around because,
    `#ifdef __attribute__` is always false
    `__has_c_attribute` is also compiler-specific

    I understand that more than one compiler supports `__attribute__` , so guarding for only one specific compiler is too restrictive.

    On the other hand, we have `__attribute__` in other places in the tree already (flash.h, fmap.h, raiden_debug_spi.c, udelay_dos.c).

    I tried what the difference is:
    with __attribute__((deprecated , attempt to use old method gives a build-time error
    without __attribute__((deprecated , same attempt gives a link-time error

    Apparently [[deprecated]] is standard since C23 as well, but is probably much too new to use right now.

    I agree that's too new, I remember contributor made a patch to be able to build without C23.

To view, visit change 86031. To unsubscribe, or for help writing mail filters, visit settings.