Anastasia Klimchuk submitted this change.

View Change


Approvals: Stefan Reinauer: Verified; Looks good to me, approved
Grant "flashrom reviewers" group -1..+2 for code review

The goal is to have the following config:
-2..+2 flashrom developers (same as it is)
-1..+2 flashrom reviewers
-1..+1 all registered users

Change-Id: Idd8aba708d0d9b8d93f4a2893dafc407d5b77de1
Reviewed-on: https://review.coreboot.org/c/flashrom/+/74691
Tested-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
---
M groups
M project.config
2 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/groups b/groups
index 579c63c..ca8045d 100644
--- a/groups
+++ b/groups
@@ -1,7 +1,9 @@
# UUID Group Name
#
+25cadc351dd0492fd2a2a1b1a8e5bb08c29e411f flashrom reviewers
db95ce11b379445ac8c5806ea0b61195555b338d flashrom developers
global:Project-Owners Project Owners
+global:Registered-Users Registered Users
user:Th3Fanbus user/Angel Pons (Th3Fanbus)
user:aklm user/Anastasia Klimchuk (aklm)
user:dhendrix user/David Hendricks (dhendrix)
diff --git a/project.config b/project.config
index 57c54c8..8c30ea3 100644
--- a/project.config
+++ b/project.config
@@ -46,7 +46,7 @@
owner = group user/David Hendricks (dhendrix)
owner = group user/build bot (Jenkins) (jenkins)
[access "refs/heads/*"]
- exclusiveGroupPermissions = create delete submit
+ exclusiveGroupPermissions = create delete label-Code-Review submit
create = group user/Anastasia Klimchuk (aklm)
create = group user/Angel Pons (Th3Fanbus)
create = group user/David Hendricks (dhendrix)
@@ -55,6 +55,8 @@
delete = group user/David Hendricks (dhendrix)
submit = group flashrom developers
label-Code-Review = -2..+2 group flashrom developers
+ label-Code-Review = -1..+2 group flashrom reviewers
+ label-Code-Review = -1..+1 group Registered Users
label-Verified = -1..+1 group flashrom developers
[access "refs/for/refs/heads/stable"]
exclusiveGroupPermissions = push

To view, visit change 74691. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: refs/meta/config
Gerrit-Change-Id: Idd8aba708d0d9b8d93f4a2893dafc407d5b77de1
Gerrit-Change-Number: 74691
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged