Attention is currently required from: Matti Finder, Peter Marheine.
4 comments:
Patchset:
Two more things to mention, we would need two more commits after this:
1) add the new code to be building on CI
It currently doesn't because libcrypto is not installed, and the option is auto.
I will look into this
2) update the `doc/dev_guide/building_from_source.rst` which is this page https://flashrom.org/dev_guide/building_from_source.html , for the same reason as there is now new optional library.
Can be a separate commit, there are a bunch of sections in the doc
File cli_classic.c:
Patch Set #8, Line 1272: any_rpmc_op
Before your question the `cli_classic_validate_singleop(&operation_specified);` before any of the op […]
Oh great, I am glad that my question turned out to be useful.
Yes, I agree with your idea to allow multiple commands chained together.
File doc/classic_cli_manpage.rst:
If your chip is detected correctly but the feature is not enabled, try using
``-c "SFDP-capable chip"`` for automatic feature detection.
I have added a quote to the error message, this should make it better to understand. […]
Yes I am also thinking on the background, what internal improvements we can make.
I think as long as cli API will stay the same (and will keep working), we can change internal implementation.
As for the manpage intro: let's keep this one. Once people start using the feature, it will soon be clear whether any more clarification is needed, or maybe it's clear already.
File doc/classic_cli_manpage.rst:
The last thing I want to ask you to add: a few examples at the end of RPMC section in the manpage, of how full command line call would look like.
Just a few, which ones would be in your opinion the most common usages.
Since you made it possible to run multiple commands in the same call, maybe also 1-2 examples with multiple commands.
Thank you!
To view, visit change 84840. To unsubscribe, or for help writing mail filters, visit settings.