Angel Pons submitted this change.
sb600spi: Cleanup spispeed and spireamode warnings
These warnings are printed at error level so they are displayed with
every invocation of flashrom. This clutters the flashrom output in the
usual case. Move warnings to debug level, add newline and clean up text.
TEST=Deploy to guybrush, observe messages are only seen when --verbose
is enabled
BUG=None
BRANCH=None
Change-Id: Idf5e735b9e504c943bf93a428da64976d723eb2c
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/58529
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M sb600spi.c
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sb600spi.c b/sb600spi.c
index 7fa01af..d5e228c 100644
--- a/sb600spi.c
+++ b/sb600spi.c
@@ -458,8 +458,8 @@
msg_pdbg("SPI read mode is %s (%i)\n",
spireadmodes[read_mode], read_mode);
if (spireadmode_idx < 0) {
- msg_perr("Warning: spireadmode not set, "
- "leaving spireadmode unchanged.");
+ msg_pdbg("spireadmode is not set, "
+ "leaving SPI read mode unchanged.\n");
}
else if (set_mode(dev, spireadmode_idx, sb600_spibar) != 0) {
return 1;
@@ -501,7 +501,7 @@
}
}
if (spispeed_idx < 0) {
- msg_perr("Warning: spispeed not set, leaving spispeed unchanged.");
+ msg_pdbg("spispeed is not set, leaving SPI speed unchanged.\n");
return 0;
}
return set_speed(dev, amd_gen, spispeed_idx, sb600_spibar);
To view, visit change 58529. To unsubscribe, or for help writing mail filters, visit settings.