Attention is currently required from: Melvyn.
Patch set 4:Code-Review +1
View Change
2 comments:
Commit Message:
Patch Set #3, Line 9: me_cleaner
Minor: Our guidelines state that commit message lines wrap at 72 characters [1]. […]
Done
Patch Set #3, Line 12: melvyn2
That would be great, let me know what needs to be done on my end.
Just restoring this patch is enough, thank you. I've added my sign-off. While at it, I also took care of my other comment about the line length.
Now, the only thing left is to have someone else approve it.
To view, visit change 58774. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If14d45c144bb32a1d1046185d4476ea29e4d0912
Gerrit-Change-Number: 58774
Gerrit-PatchSet: 4
Gerrit-Owner: Melvyn <melvyn2@brcok.tk>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Melvyn <melvyn2@brcok.tk>
Gerrit-Comment-Date: Wed, 10 Nov 2021 14:13:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Melvyn <melvyn2@brcok.tk>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment