Attention is currently required from: Thomas Heijligen, Angel Pons, qianfan, Anastasia Klimchuk.
Patch set 3:Code-Review -1
View Change
2 comments:
Patchset:
Patch Set #3:
I've added some comments on your patch. […]
I've moved unique parts of this patch (CB:70573) to a new patch (CB:71066) which is rebased on top of CB:70529.
Patch Set #3:
Giving this -1 for now to make sure this doesn't get submitted without CB:70529 (Qianfan's port which was uploaded before mine) and CB:71066 (extra features in my port rebased on top of Qianfan's code) having been reviewed.
To view, visit change 70573. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I31b86c41076cc45d4a416a73fa1131350fb745ba
Gerrit-Change-Number: 70573
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Chin <nic.c3.14@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14@gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Alexander Goncharov <chat@joursoir.net>
Gerrit-CC: qianfan <qianfanguijin@163.com>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: qianfan <qianfanguijin@163.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Mon, 19 Dec 2022 18:52:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: qianfan <qianfanguijin@163.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Comment-In-Reply-To: Nicholas Chin <nic.c3.14@gmail.com>
Gerrit-MessageType: comment