Attention is currently required from: Felix Singer, Nico Huber, Edward O'Callaghan, Angel Pons, Light.

Patch set 11:Code-Review +2

View Change

1 comment:

• File ich_descriptors.c:

  • Patch Set #7, Line 1364: int ret = read_ich_descriptors_from_dump(dump, len, &cs, &desc);

    What about you Nico?

    I also want to understand what to do with this patch. Specifically, the question whether it can cover a bug.
    The change is setting default values (all 0s). Without it, `ich_descriptors` will have garbage at the start.

    Then `read_ich_descriptors_from_dump()` is expected to initialise all fields. So if works, it doesn't matter what was at the start: 0s or garbage.
    If it doesn't work, some of the values would not be initialised (a bug). In the first case they would remain 0s, in the second case they would remain garbage (garbage can be also 0s).

    I don't know what is easier to spot: unintended 0s or garbage. Garbage can be anything, it can look like valid values too?

To view, visit change 62763. To unsubscribe, or for help writing mail filters, visit settings.