Attention is currently required from: Brian Norris, Nikolai Artemiev.
Brian Norris uploaded patch set #2 to this change.
The following approvals got outdated and were removed: Code-Review+2 by Nikolai Artemiev, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
flashrom: Don't throw around "delay 1 second" so lightly
Waiting a full second is a very long time, especially when
default_delay() chooses to busy-loop. This code has been around for a
decade, with vague references to user reports:
https://review.coreboot.org/plugins/gitiles/flashrom/+/8ab49e72af8465d4527de2ec37b22cd44f7a1169
Still, this logic does not belong in the the high-level library logic,
used by all programmers and all chips. If there is a timing issue, it
should either be encoded in the appropriate programmer or flashchip
timing.
Change-Id: Ie09651fede3f9f03425244c94a2da8bae00315fc
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
M flashrom.c
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/07/80807/2
To view, visit change 80807. To unsubscribe, or for help writing mail filters, visit settings.