Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Simon Glass.

View Change

2 comments:

• File tests/init_shutdown.c:

  • Patch Set #10, Line 53: MEC1308_SIO_PORT1

    Well you can move them to a header file

    Yes, although that would mean including more header files here ... but maybe this is fine?
    In any case, that would be in a separate patch.
    What do other people think about it? And if yes, would you prefer do that separate patch before or after this one?

• File tests/tests.c:

  • Patch Set #10, Line 92: if (current_io && current_io->outb)

    OK, so do you mean to allow current_io to be NULL as well?

    Yes! If a test wants io mocking, it sets current_io before executing whatever it is testing, and then at the end cleans up and sets current_io NULL (you can have a look at init_shutdown.c).
    So by default when test starts execution, current_io is NULL and if "do nothing" mocking is sufficient then nothing to do, NULL means "do nothing".

To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.