View Change

1 comment:

• File realtek_mst_i2c_spi.c:

  • Patch Set #6, Line 429: ret = 0;

    Updated

    >Without 'reset-mcu' now on the following else statement we specifically set ret to 0. It's kind of the program success only if both parameter check are passed so we don't want to mark ret to 0 on the first 'bus' check. Does it make sense?

    No. You are changing the behavior. The parameters are a union of state and so mutually exclusive. You are breaking one for the sake of another.

    Also I think you missed this comment
    >Better to just put comments on the commit than push over it.

    Deciding the semantics and behavior via n patch uploaded isn't a good mechanism to reach consensus.

To view, visit change 45674. To unsubscribe, or for help writing mail filters, visit settings.