I decided after much work down stream that this layer violates too much and doesn't lead to good places. A more well designed and maintainable solution is being devised downstream to allow something more in tune with upstreams well maintained control flow.

https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/+/2484119
https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/+/2486726

Once I have dealt with our issues downstream I will potentially re-propose something for upstream for consideration.

Patch set 1:Code-Review -2

View Change

To view, visit change 38671. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I73766451cd8900a9e0fe08efc7a4d81b2a35ac8d
Gerrit-Change-Number: 38671
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Wim Vervoorn <wvervoorn@eltan.com>
Gerrit-Comment-Date: Tue, 27 Oct 2020 05:04:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment