Attention is currently required from: Angel Pons, Anastasia Klimchuk.
1 comment:
Patchset:
Thank you, this is exactly what I wanted to know! […]
As you can see from the amount of tests, it's a rather new topic for
flashrom. As long as your work has no or only a marginal effect on the
actual program code, don't expect any strong opinions :)
Personally, I think testing graceful termination, same behavior from
multiple calls and things like memory leaks is a very good idea.
There are other things where I have mixed feelings: For instance
flashbuses_to_text_test_success() needs knowledge about exact
behavior. This can increase the maintenance burden (i.e. when
the strings change, the test needs to be changed too).
To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.