Attention is currently required from: Felix Singer, Edward O'Callaghan.

Patch set 2:Code-Review +1

View Change

3 comments:

• File rayer_spi.c:

  • Patch Set #2, Line 264: *prog_type = strdup(arg);

    As mentioned in CB:68230, calling `get_progtype()` here and having this function "return" the prog type instead avoids the need to `strdup()` the string. You'd need a "pointer to (pointer to (struct rayer_programmer))".

  • Patch Set #2, Line 274: NULL

    No, this changes behavior. If no programmer type is specified, the original code defaults to the first entry. You'd have to move this after the array and return a pointer to `rayer_spi_types[0]` (the initial value of `prog`).

  • Patch Set #2, Line 276: const struct rayer_programmer rayer_spi_types[] = {

    Shouldn't this be marked `static`? Not sure if it matters for constants, but if this were to be placed in the stack (it would definitely be if it were not const), things would break.

To view, visit change 68238. To unsubscribe, or for help writing mail filters, visit settings.