Alan Green has uploaded this change for review.

View Change

flashchips.c: end of line comment consistency

To allow automated tools to manipulate flashchips.c, make end of line
comment formatting more consistent. Specifically this change moves the
comma from end of line to immediately after the field value, before the
commment.

Signed-off-by: Alan Green <avg@google.com>
Change-Id: Ic4f97454766eff640b26a6c6eca29dc56c34c444
---
M flashchips.c
1 file changed, 26 insertions(+), 26 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/30/33830/1
diff --git a/flashchips.c b/flashchips.c
index 88648ad..1796127 100644
--- a/flashchips.c
+++ b/flashchips.c
@@ -2560,7 +2560,7 @@
}
},
.printlock = spi_prettyprint_status_register_plain, /* TODO: improve */
- .write = NULL /* Incompatible Page write */,
+ .write = NULL, /* Incompatible Page write */
.read = spi_chip_read,
.voltage = {2700, 3600},
},
@@ -2667,8 +2667,8 @@
.bustype = BUS_SPI,
.manufacture_id = ATMEL_ID,
.model_id = ATMEL_AT45CS1282,
- .total_size = 16896 /* No power of two sizes */,
- .page_size = 1056 /* No power of two sizes */,
+ .total_size = 16896, /* No power of two sizes */
+ .page_size = 1056, /* No power of two sizes */
/* does not support EWSR nor WREN and has no writable status register bits whatsoever */
/* OTP: 128B total, 64B pre-programmed; read 0x77 (4 dummy bytes); write 0x9A (via buffer) */
.feature_bits = FEATURE_OTP,
@@ -2699,8 +2699,8 @@
.bustype = BUS_SPI,
.manufacture_id = ATMEL_ID,
.model_id = ATMEL_AT45DB011D,
- .total_size = 128 /* or 132, determined from status register */,
- .page_size = 256 /* or 264, determined from status register */,
+ .total_size = 128, /* or 132, determined from status register */
+ .page_size = 256, /* or 264, determined from status register */
/* does not support EWSR nor WREN and has no writable status register bits whatsoever */
/* OTP: 128B total, 64B pre-programmed; read 0x77; write 0x9B */
.feature_bits = FEATURE_OTP,
@@ -2727,8 +2727,8 @@
.block_erase = spi_erase_at45db_chip,
}
},
- .unlock = spi_disable_blockprotect_at45db, /* Impossible if locked down or #WP is low */
.printlock = spi_prettyprint_status_register_at45db,
+ .unlock = spi_disable_blockprotect_at45db, /* Impossible if locked down or #WP is low */
/* granularity will be set by the probing function. */
.write = spi_write_at45db,
.read = spi_read_at45db, /* Fast read (0x0B) supported */
@@ -2741,8 +2741,8 @@
.bustype = BUS_SPI,
.manufacture_id = ATMEL_ID,
.model_id = ATMEL_AT45DB021D,
- .total_size = 256 /* or 264, determined from status register */,
- .page_size = 256 /* or 264, determined from status register */,
+ .total_size = 256, /* or 264, determined from status register */
+ .page_size = 256, /* or 264, determined from status register */
/* does not support EWSR nor WREN and has no writable status register bits whatsoever */
/* OTP: 128B total, 64B pre-programmed; read 0x77; write 0x9B */
.feature_bits = FEATURE_OTP,
@@ -2769,8 +2769,8 @@
.block_erase = spi_erase_at45db_chip,
}
},
- .unlock = spi_disable_blockprotect_at45db, /* Impossible if locked down or #WP is low */
.printlock = spi_prettyprint_status_register_at45db,
+ .unlock = spi_disable_blockprotect_at45db, /* Impossible if locked down or #WP is low */
/* granularity will be set by the probing function. */
.write = spi_write_at45db,
.read = spi_read_at45db, /* Fast read (0x0B) supported */
@@ -2783,8 +2783,8 @@
.bustype = BUS_SPI,
.manufacture_id = ATMEL_ID,
.model_id = ATMEL_AT45DB041D,
- .total_size = 512 /* or 528, determined from status register */,
- .page_size = 256 /* or 264, determined from status register */,
+ .total_size = 512, /* or 528, determined from status register */
+ .page_size = 256, /* or 264, determined from status register */
/* does not support EWSR nor WREN and has no writable status register bits whatsoever */
/* OTP: 128B total, 64B pre-programmed; read 0x77; write 0x9B */
.feature_bits = FEATURE_OTP,
@@ -2811,8 +2811,8 @@
.block_erase = spi_erase_at45db_chip,
}
},
- .unlock = spi_disable_blockprotect_at45db, /* Impossible if locked down or #WP is low */
.printlock = spi_prettyprint_status_register_at45db,
+ .unlock = spi_disable_blockprotect_at45db, /* Impossible if locked down or #WP is low */
/* granularity will be set by the probing function. */
.write = spi_write_at45db,
.read = spi_read_at45db, /* Fast read (0x0B) supported */
@@ -2825,8 +2825,8 @@
.bustype = BUS_SPI,
.manufacture_id = ATMEL_ID,
.model_id = ATMEL_AT45DB081D,
- .total_size = 1024 /* or 1056, determined from status register */,
- .page_size = 256 /* or 264, determined from status register */,
+ .total_size = 1024, /* or 1056, determined from status register */
+ .page_size = 256, /* or 264, determined from status register */
/* does not support EWSR nor WREN and has no writable status register bits whatsoever */
/* OTP: 128B total, 64B pre-programmed; read 0x77; write 0x9B */
.feature_bits = FEATURE_OTP,
@@ -2853,8 +2853,8 @@
.block_erase = spi_erase_at45db_chip,
}
},
- .unlock = spi_disable_blockprotect_at45db, /* Impossible if locked down or #WP is low */
.printlock = spi_prettyprint_status_register_at45db,
+ .unlock = spi_disable_blockprotect_at45db, /* Impossible if locked down or #WP is low */
/* granularity will be set by the probing function. */
.write = spi_write_at45db,
.read = spi_read_at45db, /* Fast read (0x0B) supported */
@@ -2867,8 +2867,8 @@
.bustype = BUS_SPI,
.manufacture_id = ATMEL_ID,
.model_id = ATMEL_AT45DB161D,
- .total_size = 2048 /* or 2112, determined from status register */,
- .page_size = 512 /* or 528, determined from status register */,
+ .total_size = 2048, /* or 2112, determined from status register */
+ .page_size = 512, /* or 528, determined from status register */
/* does not support EWSR nor WREN and has no writable status register bits whatsoever */
/* OTP: 128B total, 64B pre-programmed; read 0x77; write 0x9B */
.feature_bits = FEATURE_OTP,
@@ -2895,8 +2895,8 @@
.block_erase = spi_erase_at45db_chip,
}
},
- .unlock = spi_disable_blockprotect_at45db, /* Impossible if locked down or #WP is low */
.printlock = spi_prettyprint_status_register_at45db,
+ .unlock = spi_disable_blockprotect_at45db, /* Impossible if locked down or #WP is low */
/* granularity will be set by the probing function. */
.write = spi_write_at45db,
.read = spi_read_at45db, /* Fast read (0x0B) supported */
@@ -2909,8 +2909,8 @@
.bustype = BUS_SPI,
.manufacture_id = ATMEL_ID,
.model_id = ATMEL_AT45DB321C,
- .total_size = 4224 /* No power of two sizes */,
- .page_size = 528 /* No power of two sizes */,
+ .total_size = 4224, /* No power of two sizes */
+ .page_size = 528, /* No power of two sizes */
/* does not support EWSR nor WREN and has no writable status register bits whatsoever */
/* OTP: 128B total, 64B pre-programmed; read 0x77 (4 dummy bytes); write 0x9A (via buffer) */
.feature_bits = FEATURE_OTP,
@@ -2952,8 +2952,8 @@
.bustype = BUS_SPI,
.manufacture_id = ATMEL_ID,
.model_id = ATMEL_AT45DB321D,
- .total_size = 4096 /* or 4224, determined from status register */,
- .page_size = 512 /* or 528, determined from status register */,
+ .total_size = 4096, /* or 4224, determined from status register */
+ .page_size = 512, /* or 528, determined from status register */
/* does not support EWSR nor WREN and has no writable status register bits whatsoever */
/* OTP: 128B total, 64B pre-programmed; read 0x77; write 0x9B */
.feature_bits = FEATURE_OTP,
@@ -2994,8 +2994,8 @@
.bustype = BUS_SPI,
.manufacture_id = ATMEL_ID,
.model_id = ATMEL_AT45DB321C,
- .total_size = 4096 /* or 4224, determined from status register */,
- .page_size = 512 /* or 528, determined from status register */,
+ .total_size = 4096, /* or 4224, determined from status register */
+ .page_size = 512, /* or 528, determined from status register */
/* does not support EWSR nor WREN and has no writable status register bits whatsoever */
/* OTP: 128B total, 64B pre-programmed; read 0x77; write 0x9B */
.feature_bits = FEATURE_OTP,
@@ -3036,8 +3036,8 @@
.bustype = BUS_SPI,
.manufacture_id = ATMEL_ID,
.model_id = ATMEL_AT45DB642D,
- .total_size = 8192 /* or 8448, determined from status register */,
- .page_size = 1024 /* or 1056, determined from status register */,
+ .total_size = 8192, /* or 8448, determined from status register */
+ .page_size = 1024, /* or 1056, determined from status register */
/* does not support EWSR nor WREN and has no writable status register bits whatsoever */
/* OTP: 128B total, 64B pre-programmed; read 0x77; write 0x9B */
.feature_bits = FEATURE_OTP,

To view, visit change 33830. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic4f97454766eff640b26a6c6eca29dc56c34c444
Gerrit-Change-Number: 33830
Gerrit-PatchSet: 1
Gerrit-Owner: Alan Green <avg@google.com>
Gerrit-MessageType: newchange