Attention is currently required from: Nico Huber, Edward O'Callaghan, David Hendricks, Angel Pons, Arthur Heymans.

View Change

2 comments:

• Patchset:

  • Patch Set #1:

    This changes more paths than mentioned in the commit message. […]

    Hi Nico, as per https://doc.coreboot.org/getting_started/gerrit_guidelines.html, please provide a concrete recommendation here. What exactly would you like to see that will fix this logic for all chipsets? If you don't have time to make a recommendation, please remove your -2 so others can move things along.

• File ich_descriptors.c:

  • Patch Set #1, Line 936: == 16

    Maybe I am recognising a false pattern here but are the cases of [11, 15] also IBEX_PEAK? ifdtool. […]

    Nico verified that 16 is the correct value for Ibex Peak (the comment is somewhere in CB:54965). I can change this to `<=` if desired.

To view, visit change 57580. To unsubscribe, or for help writing mail filters, visit settings.