Nico Huber submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved
ft2232_spi: Revise error message

Reword the message and drop the error string from libftdi. It is
already printed in send_buf().

Change-Id: I125ae9ec0d5487fc26d588a7fd6c54da4ebd0d70
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/55697
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
---
M ft2232_spi.c
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ft2232_spi.c b/ft2232_spi.c
index 82777a2..d853b09 100644
--- a/ft2232_spi.c
+++ b/ft2232_spi.c
@@ -180,8 +180,7 @@
buf[1] = 0; /* Output byte ignored */
buf[2] = 0; /* Pin direction: all inputs */
if (send_buf(ftdic, buf, 3)) {
- msg_perr("Unable to set pins back inputs: (%s)\n",
- ftdi_get_error_string(ftdic));
+ msg_perr("Unable to set pins back to inputs.\n");
ret = 1;
}


To view, visit change 55697. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I125ae9ec0d5487fc26d588a7fd6c54da4ebd0d70
Gerrit-Change-Number: 55697
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Alan Green <avg@google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: merged