Attention is currently required from: Michał Żygowski, Paul Menzel.

View Change

2 comments:

• Patchset:

  • Patch Set #11:

    Sorry, meant to comment this earlier. I guess if we don't touch
    `enum chipbustype` now, it's ready?

• File chipset_enable.c:

  • Patch Set #3, Line 659: { "eSPI", BUS_LPC | BUS_FWH } };

    https://downloadmirror.intel.com/27055/eng/329957-001_eSPI_Spec_Server_Addendum_Rev0_7.pdf […]

    I would simply put `{ "eSPI", 0 }` here. "eSPI" is what the datasheet
    says, so why shouldn't flashrom print it. There is nothing we want to
    do right now wrt. the return value in this case, hence the `0`.

    This way, we wouldn't have to touch `enum chipbustype` and could avoid
    any implications there.

To view, visit change 55578. To unsubscribe, or for help writing mail filters, visit settings.