David Hendricks has uploaded this change for review.

View Change

buspirate_spi: when using pullup=on, you do not want 3v3 on the IOs, but rather use them open-drain

Change-Id: I9ac4c6b7a0079bb1022f2d70030a6eb29996108f
---
M buspirate_spi.c
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/64/23864/1

diff --git a/buspirate_spi.c b/buspirate_spi.c
index b6554ac..4c90fbc 100644
--- a/buspirate_spi.c
+++ b/buspirate_spi.c
@@ -436,6 +436,10 @@
 	
 	/* Set SPI config: output type, idle, clock edge, sample */
 	bp_commbuf[0] = 0x80 | 0xa;
+	if (pullup == 1) {
+		bp_commbuf[0] &= ~(1 << 3);
+		msg_pdbg("Pull-ups enabled, so using HiZ pin output! (Open-Drain mode)\n");
+	}
 	ret = buspirate_sendrecv(bp_commbuf, 1, 1);
 	if (ret)
 		return 1;

To view, visit change 23864. To unsubscribe, or for help writing mail filters, visit settings.