Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev.

View Change

1 comment:

• File dummyflasher.c:

  • Patch Set #14, Line 346: if (writecnt == 3)

    Oh great! Also maybe I am missing something, but why two ifs are not one if? it can do the job and t […]

    I think merging statements would make code structure look odd:

        work for both cases (1);
        if (wrsr_ext) {
            work for one case (2);
            debug print about (1) and (2);
        } else {
            debug print about (1);
        }

    I'd keep actual work and messages separate.

To view, visit change 59072. To unsubscribe, or for help writing mail filters, visit settings.