Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.

View Change

1 comment:

• File stlinkv3_spi.c:

  • Patch Set #1, Line 533: stlinkv3_spi_open(sck_freq_kHz, stlinkv3_handle

    Uh, good point.

    >>> Before this commit, the handle was closed unless register_shutdown() failed.

    I am confused, because register_shutdown is called after this line, and it was after this line before. So if stlinkv3_spi_open fails, at that point shutdown hasn't been registered yet and so handle wasn't closed. Maybe I am missing something obvious or misunderstand something?

    I don't want to do a regression, definitely don't want. I really want to make things better, not worse... sorry if my words sound as "blaming existing code".

    So, I don't want to leave this in a state which looks worse than it was. Maybe I can just fix all init error paths here? what do you think

To view, visit change 54042. To unsubscribe, or for help writing mail filters, visit settings.