Attention is currently required from: Angel Pons, Anastasia Klimchuk.

Patch set 1:-Code-Review

View Change

1 comment:

• File ene_lpc.c:

  • Patch Set #1, Line 519: = NULL

    nit: initialisation is not necessary

    heh, I knew I missed something :) it's not a nit IMHO, static analysis
    tools could complain about it.

    What I usually do to avoid such situations: declare it inline with the
    code and `const`, e.g.

        char *const p = extract_programmer_param("type");

    This way it's clear that it can never be used unitialized.

To view, visit change 52684. To unsubscribe, or for help writing mail filters, visit settings.