Attention is currently required from: Angel Pons, Brian Norris, Hsuan-ting Chen, Thomas Heijligen.
1 comment:
Patchset:
1. […]
1. Good, let's agree on `open/close` then
2. I think I see your point now. There is a "software way" to enable/disable WP, which is preferred way however not mentioned in the that error message at all.
I think this is a valid point, but adding "use the designated command" does not solve the situation. Because only the people who already know what to do can understand it. And those who don't know, what is "designated"? We can do some more thinking how to do this message right.
How about this patch goes ahead and then later we can update the message?
3. flashrom_tester only runs on ChromeOS. It checks the system in the beginning, and if it's not ChromeOS it prints a message and exits.
Me and Evan did initial research on that, we had the goal to expand flashrom_tester to run on more OSes. But then the time suddenly was over, and we are no longer on that team. From my memory, the obvious non-portable points were calls to `crossystem` command which only exists on ChromeOS, but there can be more things.
TLDR maybe this patch can go ahead with open/close, and then message can be upgraded in the next patch? if you agree, you can mark the comment as resolved!
To view, visit change 82083. To unsubscribe, or for help writing mail filters, visit settings.