Attention is currently required from: Aarya, Bill XIE, Peter Marheine.
View Change
1 comment:
File cli_classic.c:
Patch Set #8, Line 124: " --sacrifice-ratio <ratio> Maximum %% memory that is allowed for redundant\n"
And just right now, I realised manpage needs to be updated too! […]
So, I did all three things:
1) cli_classic.c , I combined the text from everyone! tell me what do you think
flashrom -h shows it, all good
2) doc/release_notes/devel.rst has the section, text copied from commit message
3) doc/classic_cli_manpage.rst also has the text, a bit longer than 1)
To view, visit change 84721. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I154e8a713f626c37dbbe118db700055b96d24803
Gerrit-Change-Number: 84721
Gerrit-PatchSet: 10
Gerrit-Owner: Bill XIE <persmule@hardenedlinux.org>
Gerrit-Reviewer: Aarya <aarya.chaumal@gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Bill XIE <persmule@hardenedlinux.org>
Gerrit-Attention: Aarya <aarya.chaumal@gmail.com>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Mon, 28 Oct 2024 08:28:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Comment-In-Reply-To: Peter Marheine <pmarheine@chromium.org>