Attention is currently required from: Nico Huber, Thomas Heijligen, Daniel Campello.
View Change
1 comment:
File libflashrom.c:
Patch Set #3, Line 527: flashrom_layout_new(&l)
perhaps remove the intermediate and use `layout` directly? seems like `l` can leak here?
To view, visit change 54284. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic48c9e73a3d00782f638f6ff41b620910b24ab6f
Gerrit-Change-Number: 54284
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Daniel Campello <campello@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Daniel Campello <campello@chromium.org>
Gerrit-Comment-Date: Mon, 17 May 2021 14:31:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment