Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons.
View Change
1 comment:
File flashrom.c:
Patch Set #1, Line 1937: spi_master_no_4ba_modes
sort of but not really. This is a chip bustype check not a master bustype check. […]
Could we skip this entire section on 4ba for non-SPI masters?
To view, visit change 71269. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7cce4f9c032d33c01bf616e27a50b9727a40fe1b
Gerrit-Change-Number: 71269
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall@puri.sm>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nikolai Artemiev <nartemiev@google.com>
Gerrit-CC: Sam McNally <sammc@google.com>
Gerrit-CC: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Fri, 06 Jan 2023 10:48:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment