Attention is currently required from: Thomas Heijligen, Angel Pons.

View Change

1 comment:

• File hwaccess.h:

  • Patch Set #1, Line 36:

    #define pci_mmio_writeb mmio_le_writeb
    #define pci_mmio_writew mmio_le_writew
    #define pci_mmio_writel mmio_le_writel
    #define pci_mmio_readb mmio_le_readb
    #define pci_mmio_readw mmio_le_readw
    #define pci_mmio_readl mmio_le_readl
    

    I've replaced the calls in https://review.coreboot.org/c/flashrom/+/59016. […]

    I see, but I don't understand why. These macros carry some information at least:
    That for PCI config one should expect little-endian. Without them, every author
    needs to be reminded, don't they?

To view, visit change 58883. To unsubscribe, or for help writing mail filters, visit settings.