Attention is currently required from: Anastasia Klimchuk, Alexander Goncharov.
6 comments:
File Makefile:
Patch Set #1, Line 963: $(if $(findstring $(HAS_SPHINXBUILD),yes), man8/$(PROGRAM).8)
`$(call has_dependency,$(HAS_SPHINXBUILD),man8/$(PROGRAM). […]
Done
Patch Set #1, Line 1024: @echo "Found \"sphinx-build\" to generate man-pages: $(HAS_SPHINXBUILD)"
The previous lines have the pattern of message […]
Done
Patch Set #1, Line 1036: man8/$(PROGRAM).8: doc/*
There is a ticket reported for this bit: https://ticket.coreboot. […]
This target is now only called if sphinx-build is found.
If you try to call it manually and don't have sphinx-build installed, it trows an error.
Patch Set #1, Line 1059: $(call install-man)
`$(call has_dependency,$(HAS_SPHINXBUILD),install-man)`
The patch has changes. Not needed any more
install: install-bin install-bash $(call install-man)
install-bin: $(PROGRAM)$(EXEC_SUFFIX)
mkdir -p $(DESTDIR)$(PREFIX)/sbin
$(INSTALL) -m 0755 $(PROGRAM)$(EXEC_SUFFIX) $(DESTDIR)$(PREFIX)/sbin
install-bash: $(PROGRAM).bash
mkdir -p $(DESTDIR)$(BASHCOMPDIR)
$(INSTALL) -m 0644 $(PROGRAM).bash $(DESTDIR)$(BASHCOMPDIR)
install-man: man8/$(PROGRAM).8
mkdir -p $(DESTDIR)$(MANDIR)/man8
$(INSTALL) -m 0644 man8/$(PROGRAM).8 $(DESTDIR)$(MANDIR)/man8
install-lib: libflashrom.a include/libflashrom.h
mkdir -p $(DESTDIR)$(PREFIX)/lib
$(INSTALL) -m 0644 libflashrom.a $(DESTDIR)$(PREFIX)/lib
mkdir -p $(DESTDIR)$(PREFIX)/include
$(INSTALL) -m 0644 include/libflashrom.h $(DESTDIR)$(PREFIX)/include
libinstall: install-lib
How about doing these changes as a separate patch? Because it looks like a refactoring and not an es […]
I throw my first attempt on the garbage. This one is much cleaner.
File Makefile.include:
define install-man
$(if $(findstring $(HAS_SPHINXBUILD),yes), install-man)
endef
You can make this macro/fun more universal, e.g: […]
Done
To view, visit change 74519. To unsubscribe, or for help writing mail filters, visit settings.