Attention is currently required from: Edward O'Callaghan, Alexander Goncharov.

View Change

2 comments:

• File ch341a_spi.c:

  • Patch Set #3, Line 80:

    	struct libusb_transfer *transfer_out;
    	struct libusb_transfer *transfer_ins[USB_IN_TRANSFERS];
    
    	/* Accumulate delays to be plucked between CS deassertion and CS assertions. */
    	unsigned int stored_delay_us;
    
    	struct libusb_device_handle *handle;
    

    Will default values for these be the same as before?
    If not, they should be set in init function. Although 0s and NULLs are probably default initialisation anyway?

  • Patch Set #3, Line 461:

    msg_pwarn("Cannot detach the existing USB driver. Claiming the interface may fail. %s\n",
    			libusb_error_name(ret));
    

    Is this an error branch? It should `goto free_data` then. Or maybe `goto close_handle` ?

To view, visit change 72807. To unsubscribe, or for help writing mail filters, visit settings.