Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk.

View Change

1 comment:

• File dummyflasher.c:

  • Patch Set #2, Line 910:

    What if you try: […]

    1) dummy_shutdown() has as an argument `void *data`, not `struct flashctx *flash`. It's just a pointer to the data. Of course, we can free the data, but we cannot make `rmst.(par/spi/opaque).data` equals NULL. If we do `emu_data = NULL`, it makes the _local_ pointer equals NULL.

    2) When we talk about data ownership, the last owner of the data must release this data. Not the first, because it can bring us more problems.

    I'll try to figure out what I can add to the unit tests.

To view, visit change 72408. To unsubscribe, or for help writing mail filters, visit settings.