Attention is currently required from: ChrisEric1 CECL, Thomas Heijligen.
View Change
3 comments:
Patchset:
File sb600spi.c:
Patch Set #6, Line 56: uint8_t RZN32BM = 0;
Accessing larger than 16M is indeed a problem. https://review.coreboot.org/c/flashrom/+/71565 fixes it.
Patch Set #6, Line 128: (rev == 0x51 || rev == 0x59 || rev == 0x61)
Those cases are covered below...
To view, visit change 72020. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7452b169ad89e0a884a46acc6a0499e97bb6ff7e
Gerrit-Change-Number: 72020
Gerrit-PatchSet: 6
Gerrit-Owner: ChrisEric1 CECL <christopherericlentocha@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: ChrisEric1 CECL <christopherericlentocha@gmail.com>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Comment-Date: Wed, 18 Jan 2023 06:35:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment