Attention is currently required from: Anastasia Klimchuk, Matti Finder.

View Change

1 comment:

• File meson.build:

  • Patch Set #1, Line 179: add_project_arguments('-DCONFIG_RPMC_ENABLED=1', language : 'c')

    rpmc should be added as an option (in `meson_options.txt`), so users can assert they want it enabled and the build will fail if dependencies aren't met.

    If you do:

    ```
    option('rpmc', type : 'feature', value : 'auto', description : 'Support for Replay Protected Monotonic Counter (RPMC) commands as specified by JESD260')
    ```

    Then here libcrypto can be required sometimes:

    ```
    libcrypto = dependency('libcrypto', required : get_option('rpmc'), version : '>=3.0.0')

    ...

    if libcrypto.found()
      # Add options for RPMC implementation
      ...
    endif
    ```

    ..and you don't really need the `message()` anymore since a user can force the build to fail if they want RPMC support but are missing dependencies, instead of manually looking for the message.

To view, visit change 84840. To unsubscribe, or for help writing mail filters, visit settings.