Patch Set 3:

Elyes, did you check if the upstream (Linux kernel) checkpatch
also complains about these `else`s?

As I told you on IRC, that would be enough reason for me to
merge these patches.

Thank you for the review.
Yes I did.
I've used https://raw.githubusercontent.com/torvalds/linux/master/scripts/checkpatch.pl
and here is for example the log of "./checkpatch.pl --no-tree --file ichspi.c" : https://pastebin.com/H9W73U6h
as you can see, we have :
"WARNING: else is not generally useful after a break or return
#1249: FILE: ichspi.c:1249:
+ return 4 * 1024;
+ } else {
"

View Change

To view, visit change 33347. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie000732158f27632ee92404c66a9aab43f3b374c
Gerrit-Change-Number: 33347
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Fri, 21 Jun 2019 14:37:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment