Attention is currently required from: Xiang Wang.
View Change
1 comment:
File bitbang_spi.c:
Patch Set #1, Line 71: cpha
I think you need to take a closer look at https://en.wikipedia. […]
Have you tested this patch? Note that the clock phase is conditionally shifted in `bitbang_spi_send_command()`.
To view, visit change 49271. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I415a528c013f1a523e883d812b6890be39bfcc7b
Gerrit-Change-Number: 49271
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Xiang Wang <merle@hardenedlinux.org>
Gerrit-Attention: Xiang Wang <merle@hardenedlinux.org>
Gerrit-Comment-Date: Sun, 10 Jan 2021 14:13:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Xiang Wang <merle@hardenedlinux.org>
Gerrit-MessageType: comment