Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
View Change
1 comment:
File spi.c:
Patch Set #1, Line 151:
if (data)
rmst.spi.data = data;
I agree that par_master and opaque_master could also benefit from this API change, but they can be a […]
Yes, I agree on follow-up for par/opaque, but this follow up should actually happen for this approach to work. I can do it myself, or not myself, in any case I would really appreciate to have some kind of coordination before!
Also CB:51761 is still needed, but will need rebasing of course.
To view, visit change 54066. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0c753b3db050fb87d4bbe2301a7ead854f28456f
Gerrit-Change-Number: 54066
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Wed, 12 May 2021 10:13:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment