Attention is currently required from: Anastasia Klimchuk.
View Change
1 comment:
File mec1308.c:
Patch Set #1, Line 115: #endif /* UNIT_TEST_ENV */
I know it won't be as easy, but I'd much prefer such mocks in
separate compilation units. Instead of the macros, you'd have
to provide implementations for inb() and outb(), I guess.
To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3af612defe1af3850dfc1626a208d873e3a3eddc
Gerrit-Change-Number: 51487
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Mon, 22 Mar 2021 23:44:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment