Attention is currently required from: ChrisEric1 CECL, Nicholas Chin.

View Change

6 comments:

• Patchset:

  • Patch Set #3:

    Hello! […]

    1. Ok,
    2. Yes, thats fine. But I missed one thing. Can you add `vl805` also to `meson_options.txt` under `option('programmer', ...`
    3. I'll also have a closer look for the RDID4. This has something to do with how many ID bytes were queried IIRC.

    I've found also an VL805 PCI card in my pile of stuff and will give your patch a try tomorrow.

• File flashchips.c:

  • Patch Set #8, Line 19126: .probe = PROBE_SPI_RDID4,

    This should also be an other commit. Can be before this or after.

• File flashrom.8.tmpl:

  • Patch Set #8, Line 1706: and raw memory access

    pci configutation space is enough.

• File vl805.c:

  • Patch Set #3, Line 38: static struct pci_dev *dev = NULL;

    Cannot do that, this part is outside of the global which needs it: […]

    This was referred to `static struct pci_dev *dev = NULL`, not `dev_entries`.

    The plan is to have the `pci_dev` handle in a data struct, allocated by `vl805_init()` and passed on via the `flashxtx *ctx->mst->spi.data`.

    So
    ```
    void vl805_setregval(int reg, uint32_t val)
    ```
    becomes
    ```
     void vl805_setregval(struct pci_dev *dev, int reg, uint32_t val)
    ```

    And `vl805_spi_send_command` gets the pci_dev* like in `pickit2_spi.c:402`

  • Patch Set #3, Line 72:

    uint32_t indata = 0;
    	unsigned int curwritecnt = 0;
    	unsigned int curreadcnt = 0;
    

    I don't understand what you are trying to say, if you remove the highlighted part, it fails to build […]

    The ` = 0` is not needed for each of them. A declaration of those variables is sufficient. They don't need to be initialized.

  • Patch Set #3, Line 107: static const struct spi_master spi_master_vl805 = {

    I have no clue right now, but I added it in to see if it works later.

    Done

To view, visit change 72057. To unsubscribe, or for help writing mail filters, visit settings.