(2 comments)

As this changes the timing, I would like some confirmation that
it doesn't break nicintel_spi (the only bitbang master that sets
.half_period). I would expect it to work fine, though, and assume
that the delay is not needed for it anyway.

This was tested with the forementioned device, no signs of breakage were shown (I can dig up the device ID).

Patch set 2:Code-Review +1

View Change

To view, visit change 26946. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3430a9df34844cdfa82e109456be788eaa1789a
Gerrit-Change-Number: 26946
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Thompson <daniel.thompson@linaro.org>
Gerrit-Reviewer: Idwer Vollering <vidwer@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 25 Jun 2018 01:03:02 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes