Attention is currently required from: Nico Huber, Edward O'Callaghan, Nikolai Artemiev, Anastasia Klimchuk.
7 comments:
File cli_classic.c:
const bool
nit: missing space before `|`
For another patch: Shouldn't these be short-circuiting logical OR `||` instead? The `|` is a bit-wise OR.
File writeprotect.h:
Patch Set #3, Line 21: #define MAX_WP_RANGES 128
Why 128?
Patch Set #3, Line 31: uint32_t
Missing header include
Missing header include
Patch Set #3, Line 38: size_t
Missing header include
File writeprotect.c:
I find it hard to evaluate an interface without seeing its implementation. I think it would be better to remove everything in one commit, then gradually (re)implement the write-protect functionality in subsequent patches.
I imagine the reason to go with this approach is to minimize changes in cli_classic.c code, especially if the CLI remains the same. I understand that removing and re-adding the CLI code is cumbersome, but I don't think it's that much effort to do.
I'd like to know what others think about this.
To view, visit change 58474. To unsubscribe, or for help writing mail filters, visit settings.