Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons.
Patch set 3:Code-Review +1
View Change
1 comment:
Patchset:
Patch Set #1:
It would make the build more complex. […]
How about we define something in the Makefile that can be used literally? roughly:
LIBPCI_VERSION := "no PCI support"
ifeq ($(USE_LIBPCI),yes)
LIBPCI_VERSION := "libpci $(shell pkg-config --modversion libpci 2>/dev/null)"
endif
CFLAGS += -DLIBPCI_VERSION='$(LIBPCI_VERSION)'
To view, visit change 62833. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0b5dbf3bd82a2ffe64b73881383e92f7dad4c382
Gerrit-Change-Number: 62833
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Thu, 17 Mar 2022 21:43:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Heijligen <src@posteo.de>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment