Attention is currently required from: Felix Singer, Angel Pons.

View Change

1 comment:

• File flashrom.c:

  • Patch Set #1, Line 1937: spi_master_no_4ba_modes

    Wouldn't it make more sense to add the bustype check inside this function?

    sort of but not really. This is a chip bustype check not a master bustype check.

    Adding a predicate to `spi_master_no_4ba_modes()` is not related to preventing the subsequent calls to `spi_{enter,exit}_4ba()`.

    I think what you are asking for is a `spi_chip_4ba()` func which I have now done?

To view, visit change 71269. To unsubscribe, or for help writing mail filters, visit settings.