Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.

1 comment:

File tests/lifecycle.c:
- Patch Set #1, Line 53:
```
	printf("Testing flashrom_flash_probe for programmer=%s, chip=%s ... \n", prog->name, chip_name);
	assert_int_equal(0, flashrom_flash_probe(&flashctx, flashprog, chip_name));
	printf("... flashrom_flash_probe for programmer=%s successful\n", prog->name);
```
  technically this block is the real meaning of the test and the rest is mostly almost exact the same as run_basic_lifecycle() and so perhaps could we just consume a function pointer into a internal run_lifecycle() function that does the following pattern:
```
run_lifecylcle():
   init()
   fx()
   deinit()
.
```
  This way all the lifecycle test variants call this with their particular fx() intermediate details such as the above probe block.
  This avoids duplication and makes the foundations of this test infrastructure far more extensible for other contributions.

To view, visit change 59741. To unsubscribe, or for help writing mail filters, visit settings.