Attention is currently required from: Michał Żygowski, Angel Pons, Michael Niewöhner.

View Change

1 comment:

• File acpi_ec.h:

  • Patch Set #4, Line 44:

    bool ec_write_cmd(uint8_t control_port, uint8_t cmd, unsigned int max_checks);
    bool ec_read_byte(uint8_t control_port, uint8_t data_port, uint8_t *data,
    		  unsigned int max_checks);
    bool ec_write_byte(uint8_t control_port, uint8_t data_port, uint8_t data,
    		   unsigned int max_checks);
    
    

    The EFI firmware update application talks through multiple port pairs. […]

    Hmmm, let me ask this then: Was the `portpair` option of your driver
    tested for non-default values? If not, I'd rather not add code for it
    until somebody needs it.

    Another option to settle this would be to add all this as generic
    `ec` code (without the `acpi` prefix) and only rename the two functions
    below to something like acpi_ec_read()/acpi_ec_write(). The concept of
    the status/command + data ports is older than ACPI anyway. Technically,
    also not EC specific, but I think for now we can assume that we'll only
    need it for ECs.

To view, visit change 55714. To unsubscribe, or for help writing mail filters, visit settings.