View Change

2 comments:

• File fmap.h:

  • Patch Set #5, Line 27: struct fmap_area areas[];

    You could just give it a number, e.g. MAX_ROMLAYOUT. Dynamic
    allocation would be cleaner, IMHO (or just inline the decoding
    into the processing or the other way around).

• File fmap.c:

  • Patch Set #5, Line 63: fmap->ver_major = dump[i++];

    overflow check?

    Though, I think it would be much easier to check only two times.
    One time for `sizeof(struct fmap)` and one time for `nareas`.

To view, visit change 23203. To unsubscribe, or for help writing mail filters, visit settings.