>> This should be rebased on the SPI command set commit, and add and
>> use
>> another class. Looks very good otherwise.
>
> Big problem is that this change "23259" depends on already verified
> "23258" and its' "FEATURE_ERASED_ZERO" . When I try rebasing it on
> top of "23262" (SPI command set) I get a -1 build error from
> Jenkins. I'm not sure what to do next...

You need all three commits (23258, 23259, 23262) on a single branch.
IMO, easiest way is to check this one out (which will include 23258
as its parent) and rebase on 23262.

  git fetch ssh://Nico@review.coreboot.org:29418/flashrom refs/changes/59/23259/8 && git checkout FETCH_HEAD
  git fetch ssh://Nico@review.coreboot.org:29418/flashrom refs/changes/62/23262/5 && git rebase FETCH_HEAD
  git push ...

Also its' a bit unclear to
me, what did you mean by "add and use another class" for this
commit. Please could you clarify?

I meant you should extend the enum added by 23262 (e.g. add
SPI_EDI) and set `.spi_cmd_set = SPI_EDI,` in the flashchips.c
entry.

View Change

To view, visit change 23259. To unsubscribe, or for help writing mail filters, visit settings.